Reduce typed app-server request serialization overhead - #34766
Merged
copyberry[bot] merged 1 commit intoJul 22, 2026
Merged
Conversation
## What changed - Use `ClientRequest::method_name()` directly when preparing typed request diagnostics for in-process and remote clients. - Allocate the owned method name only when constructing an error. - Remove the serialization-based method lookup and the redundant allocating `ClientRequest::method()` helper. GitOrigin-RevId: 93859e512a4f20204e0db4f929a2baebe4374ec5
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/93859e512a4f20204e0db4f929a2baebe4374ec5
branch
from
July 22, 2026 14:51
eeba9b8 to
e370d23
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/93859e512a4f20204e0db4f929a2baebe4374ec5
branch
July 22, 2026 14:52
yuanhao-quantelai
temporarily deployed
to
issue-triage
July 22, 2026 15:06 — with 
GitHub Actions
Inactive
yuanhao-quantelai
temporarily deployed
to
issue-triage
July 22, 2026 15:06 — with
GitHub Actions
Inactive
yuanhao-quantelai
temporarily deployed
to
issue-triage
July 22, 2026 15:06 — with
GitHub Actions
Inactive
yuanhao-quantelai
temporarily deployed
to
issue-triage
July 22, 2026 15:07 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce typed app-server request serialization overhead
What changed
ClientRequest::method_name()directly when preparing typed requestdiagnostics for in-process and remote clients.
ClientRequest::method()helper.